Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cmake): update tianmu cmake file(#749) #750

Merged
merged 1 commit into from
Oct 19, 2022
Merged

feat(cmake): update tianmu cmake file(#749) #750

merged 1 commit into from
Oct 19, 2022

Conversation

RingsC
Copy link
Contributor

@RingsC RingsC commented Oct 18, 2022 •
edited by Nliver
Loading

Summary about this PR

To support portable tianmu cmake system vars. To set the var values by input values.

Issue Number: close #749

Tests Check List

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Changelog

  • New Feature
  • Bug Fix
  • Improvement
  • Performance Improvement
  • Build/Testing/CI/CD
  • Documentation
  • Not for changelog (changelog entry is not required)

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features

@mergify
Copy link
Contributor

mergify bot commented Oct 18, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the PR-feature feature for pull request label Oct 18, 2022
hustjieke
hustjieke approved these changes Oct 19, 2022
View reviewed changes
Copy link
Collaborator

@hustjieke hustjieke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RingsC
feat(cmake): update tianmu cmake file(#749)
f80f059 
To support portable tianmu cmake system vars. To set the var values by input values.
DandreChen
DandreChen approved these changes Oct 19, 2022
View reviewed changes
Copy link
Collaborator

@DandreChen DandreChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lujiashun
lujiashun approved these changes Oct 19, 2022
View reviewed changes
Copy link

@lujiashun lujiashun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit da23ed2 into stoneatom:stonedb-8.0-dev Oct 19, 2022
@RingsC RingsC deleted the stonedb-8.0-dev-tianmu-cmake branch October 19, 2022 05:37
@Nliver Nliver added this to the StoneDB_8.0_v1.0.0 milestone Apr 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lujiashun lujiashun lujiashun approved these changes

@DandreChen DandreChen DandreChen approved these changes

@hustjieke hustjieke hustjieke approved these changes

Assignees

@RingsC RingsC

Labels
PR-feature feature for pull request
Projects
StoneDB for MySQL 8.0
Status: Done
Milestone
StoneDB_8.0_v1.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@RingsC @hustjieke @DandreChen @lujiashun @Nliver